feat: add --no-modules-global support
#1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also rustwasm/wasm-bindgen#2700. |
|
We are using this downstream and it's working well. |
|
Hi there, any thoughts on this? |
|
LGTM (as a random person on the internet with no approval/commit rights) |
|
Hi there, it's been another month. Any thoughts? |
|
LGTM |
davehorner
reviewed
Sep 30, 2022
|
No clue, we've been using it for a while without issue. |
|
I'd really like to have this feature as well, but apparently wasm-pack is lacking maintainers I wonder if I should use wasm-bindgen cli directly for this while waiting (?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pass-through support for the
wasm-bindgenflag--no-modules-global, which is very useful when building/running WASM in certain scenarios (browser extensions in particular).Supercedes #860 which was mysteriously closed last summer.
Closes #729.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨